b0241d8b0e588dc8d2730729b0864d1e716a93b8,droid-core/src/main/java/uk/gov/nationalarchives/droid/core/BinarySignatureIdentifier.java,BinarySignatureIdentifier,checkForExtensionsMismatches,#IdentificationResultCollection#String#,224

Before Change


            IdentificationResultCollection results, String fileExtension) {
        if (fileExtension == null || fileExtension.isEmpty()) {
            FileFormatCollection allFormats = sigFile.getFileFormatCollection();
            for (IdentificationResult result : results.getResults()) {
                final String resultPUID = result.getPuid();
                final FileFormat format = allFormats.getFormatForPUID(resultPUID);
                if (format.getNumExtensions() > 0) {

After Change


            IdentificationResultCollection results, String fileExtension) {
        if (fileExtension == null || fileExtension.isEmpty()) {
            FileFormatCollection allFormats = sigFile.getFileFormatCollection();
            final List<IdentificationResult> theResults = results.getResults();
            final int numResults = theResults.size(); // garbage reduction: use indexed loop instead of allocating iterator.
            for (int i = 0; i < numResults; i++) {
                final IdentificationResult result = theResults.get(i);
                final String resultPUID = result.getPuid();
                final FileFormat format = allFormats.getFormatForPUID(resultPUID);
                if (format.getNumExtensions() > 0) {