87e88bec3f2e5935e69071c3c50ab2b821f76f0e,src/com/mebigfatguy/fbcontrib/detect/CollectionNamingConfusion.java,CollectionNamingConfusion,checkConfusedName,#String#String#,136
Before Change
&& signature.startsWith("Ljava/util/")) {
String clsName = SignatureUtils.stripSignature(signature);
JavaClass cls = Repository.lookupClass(clsName);
if (cls.implementationOf(MAP_CLASS) && !name.endsWith("map")
|| (cls.implementationOf(SET_CLASS) && !name.endsWith("set"))
|| (cls.implementationOf(LIST_CLASS) && !name.endsWith("list"))
|| (cls.implementationOf(QUEUE_CLASS) && !name.endsWith("queue"))) {
After Change
String clsName = SignatureUtils.stripSignature(signature);
JavaClass cls = Repository.lookupClass(clsName);
if ((cls.implementationOf(mapInterface) && !name.endsWith("map")) || (cls.implementationOf(setInterface) && !name.endsWith("set"))
|| (cls.implementationOf(listInterface) && !name.endsWith("list")) || (cls.implementationOf(queueInterface) && !name.endsWith("queue"))) {
return true;
}
}