9c0b272a39e6c44f854e78dd1d0ffadd492f59d4,httpcore5-testing/src/test/java/org/apache/hc/core5/testing/classic/TestClassicHttp.java,TestClassicHttp,testHttpPostsWithExpectContinue,#,426

Before Change


        this.server.start();

        // Activate 'expect: continue' handshake
        final DefaultBHttpClientConnection conn = client.createConnection();
        final HttpHost host = new HttpHost("localhost", this.server.getPort());

        try {
            for (int r = 0; r < reqNo; r++) {
                if (!conn.isOpen()) {
                    client.connect(host, conn);
                }

                final BasicClassicHttpRequest post = new BasicClassicHttpRequest("POST", "/");
                final byte[] data = testData.get(r);
                final ByteArrayEntity outgoing = new ByteArrayEntity(data);
                outgoing.setChunked(true);
                post.setEntity(outgoing);

                final ClassicHttpResponse response = this.client.execute(post, host, conn);
                final byte[] received = EntityUtils.toByteArray(response.getEntity());
                final byte[] expected = testData.get(r);

                Assert.assertEquals(expected.length, received.length);
                for (int i = 0; i < expected.length; i++) {
                    Assert.assertEquals(expected[i], received[i]);
                }
                if (!this.client.keepAlive(post, response)) {
                    conn.close();
                }
            }

            //Verify the connection metrics
            final HttpConnectionMetrics cm = conn.getMetrics();
            Assert.assertEquals(reqNo, cm.getRequestCount());
            Assert.assertEquals(reqNo, cm.getResponseCount());
        } finally {
            conn.close();

After Change


        });

        this.server.start();
        this.client.start();

        final HttpCoreContext context = HttpCoreContext.create();
        final HttpHost host = new HttpHost("localhost", this.server.getPort());

        for (int r = 0; r < reqNo; r++) {
            final BasicClassicHttpRequest post = new BasicClassicHttpRequest("POST", "/");
            final byte[] data = testData.get(r);
            final ByteArrayEntity outgoing = new ByteArrayEntity(data);
            outgoing.setChunked(true);
            post.setEntity(outgoing);

            final ClassicHttpResponse response = this.client.execute(host, post, context);
            final byte[] received = EntityUtils.toByteArray(response.getEntity());
            final byte[] expected = testData.get(r);

            Assert.assertEquals(expected.length, received.length);
            for (int i = 0; i < expected.length; i++) {
                Assert.assertEquals(expected[i], received[i]);
            }
            this.client.keepAlive(post, response, context);
        }
    }