f62214076cf486e62332a7d39ebf40b179c018b2,src/test/java/org/datadog/jmxfetch/TestApp.java,TestApp,testDomainRegex,#,118

Before Change


    @Test
    public void testDomainRegex() throws Exception {
        // We expose a few metrics through JMX
        MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();

        ObjectName includeObjectName1 = new ObjectName("org.datadog.jmxfetch.includeme:type=AType");
        ObjectName includeObjectName2 = new ObjectName("org.datadog.jmxfetch.includeme.too:type=AType");
        ObjectName excludeObjectName = new ObjectName("org.datadog.jmxfetch.includeme.not.me:type=AType");
        SimpleTestJavaApp testApp = new SimpleTestJavaApp();
        mbs.registerMBean(testApp, includeObjectName1);
        mbs.registerMBean(testApp, includeObjectName2);
        mbs.registerMBean(testApp, excludeObjectName);

        // Initializing application
        AppConfig appConfig = new AppConfig();
        App app = CommonTestSetup.initApp("jmx_domain_regex.yaml", appConfig);

        // Collecting metrics
        app.doIteration();
        LinkedList<HashMap<String, Object>> metrics = ((ConsoleReporter) appConfig.getReporter()).getMetrics();

        // First filter 15 = 13 metrics from java.lang + 3 metrics explicitly defined - 1 implicitly defined in exclude section
        assertEquals(15, metrics.size());

        mbs.unregisterMBean(includeObjectName1);
        mbs.unregisterMBean(includeObjectName2);
        mbs.unregisterMBean(excludeObjectName);
    }

    @Test

After Change


    public void testDomainRegex() throws Exception {
        // We expose a few metrics through JMX
        SimpleTestJavaApp testApp = new SimpleTestJavaApp();
        registerMBean(testApp, "org.datadog.jmxfetch.includeme:type=AType");
        registerMBean(testApp, "org.datadog.jmxfetch.includeme.too:type=AType");
        registerMBean(testApp, "org.datadog.jmxfetch.includeme.not.me:type=AType");

        // Initializing application