76614224338cbbb42c707394eec4147aac8d4ce0,BVAndroidSDK/src/com/bazaarvoice/BazaarRequest.java,BazaarRequest,displayParamsToURL,#DisplayParams#,584
Before Change
if (params.getFilters() != null) {
//char separator = url.contains("?") ? '&' : '?';
for (String filter : params.getFilters()) {
url += separator + filter;
//separator = '&';
}
}
url = addURLParameter(url, "search", params.getSearch());
if (params.getLocale() != null) {
url = addURLParameter(url, "locale", params.getLocale() + "");
}
url = addURLParameter(url, "offset", params.getOffset());
url = addURLParameter(url, "limit", params.getLimit());
url = addURLParameter(url, "excludeFamily", params.getExcludeFamily());
url = addURLParameter(url, "include", params.getIncludes());
url = addURLParameter(url, "attributes", params.getAttributes());
url = addURLParameter(url, "stats", params.getStats());
url = addURLParameter(url, "sort", params.getSort());
//char separator = url.contains("?") ? '&' : '?';
if (params.getSortType() != null) {
for (String s : params.getSortType()) {
url += separator + s;
separator = '&';
}
}
if (params.getSearchType() != null) {
for (String s : params.getSearchType()) {
url += separator + s;
separator = '&';
}
}
if (params.getLimitType() != null) {
for (String limit : params.getLimitType()) {
url += separator + limit;
separator = '&';
}
}
After Change
private String displayParamsToURL(DisplayParams params) {
char separator = '&';
StringBuilder url = new StringBuilder();
if (params.getFilters() != null) {
for (String filter : params.getFilters()) {
url.append(separator);
url.append(filter);
}
}
url.append(addURLParameter("search", params.getSearch()));
if (params.getLocale() != null) {
url.append(addURLParameter("locale", params.getLocale()));
}
url.append(addURLParameter("offset", params.getOffset()));
url.append(addURLParameter("limit", params.getLimit()));
url.append(addURLParameter("excludeFamily", params.getExcludeFamily()));
url.append(addURLParameter("include", params.getIncludes()));
url.append(addURLParameter("attributes", params.getAttributes()));
url.append(addURLParameter("stats", params.getStats()));
url.append(addURLParameter("sort", params.getSort()));
//char separator = url.contains("?") ? '&' : '?';
if (params.getSortType() != null) {
for (String s : params.getSortType()) {
url.append(separator + s);
}
}
if (params.getSearchType() != null) {
for (String s : params.getSearchType()) {
url.append(separator + s);
}
}
if (params.getLimitType() != null) {
for (String limit : params.getLimitType()) {
url.append(separator + limit);
}
}
return url.toString();