1cb8da7d7e37da592961ee104b4aa63c5b832636,ipojo/webconsole-plugin/src/main/java/org/apache/felix/ipojo/webconsole/IPOJOPlugin.java,IPOJOPlugin,getAllFactories,#PrintWriter#,261
Before Change
*/
private void getAllFactories(PrintWriter pw) throws IOException {
try {
JSONObject resp = new JSONObject();
// Statline:
resp.put("count", m_factories.size());
resp.put("valid_count", StateUtils.getValidFactoriesCount(m_factories));
resp.put("invalid_count", StateUtils.getInvalidFactoriesCount(m_factories));
// End statline
JSONArray factories = new JSONArray();
for (Factory factory : m_factories) {
String version = factory.getVersion();
String name = factory.getName();
String state = StateUtils.getFactoryState(factory.getState());
String bundle = factory.getBundleContext().getBundle().getSymbolicName()
+ " (" + factory.getBundleContext().getBundle().getBundleId() + ")";
JSONObject fact = new JSONObject();
fact.put("name", name);
if (version != null) {
fact.put("version", version);
}
fact.put("bundle", bundle);
fact.put("state", state);
factories.put(fact);
}
resp.put("data", factories);
pw.print(resp.toString());
} catch (JSONException e) {
// Propagate the exception.
throw new IOException(e.toString());
After Change
* @param pw the writer when the json object is printed
* @throws IOException the JSON object cannot be written
*/
private void getAllFactories(JSONWriter pw) throws IOException {
pw.object();
// Statline:
pw.key("count");
pw.value(m_factories.size());
pw.key("valid_count");
pw.value(StateUtils.getValidFactoriesCount(m_factories));
pw.key("invalid_count");
pw.value(StateUtils.getInvalidFactoriesCount(m_factories));
// End statline
pw.key("data");
pw.array();
for (Factory factory : m_factories) {
String version = factory.getVersion();
String name = factory.getName();
String state = StateUtils.getFactoryState(factory.getState());
String bundle = factory.getBundleContext().getBundle().getSymbolicName()
+ " (" + factory.getBundleContext().getBundle().getBundleId() + ")";
pw.object();
pw.key("name");
pw.value(name);
if (version != null) {
pw.key("version");
pw.value(version);
}
pw.key("bundle");
pw.value(bundle);
pw.key("state");
pw.value(state);
pw.endObject();
}
pw.endArray();
pw.endObject();
}
/**