155db8bd5c6e4ffe067d579d09f368b541925ecf,agent/src/main/java/org/jboss/byteman/agent/adapter/RuleCheckMethodAdapter.java,RuleCheckMethodAdapter,checkBindings,#,69
Before Change
Binding binding = bindingIter.next();
if (binding.isRecipient()) {
if ((access & Opcodes.ACC_STATIC) != 0) {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found invalid recipient binding " + binding + " checking static method " + name + descriptor);
}
transformContext.warn(name, descriptor, "found invalid recipient binding " + binding + " injecting into static method");
}
} else if (binding.isParam()) {
int idx = binding.getIndex();
if (idx > parameterCount) {
// parameter out of range
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found out of range parameter binding " + binding + " checking method " + name + descriptor);
}
transformContext.warn(name, descriptor, "found out of range parameter binding " + binding);
} else {
binding.setDescriptor(parameterTypenames.get(idx - 1));
}
} else if (binding.isReturn()) {
// this is a valid reference in an AT EXIT rule and in an AFTER INVOKE
// but only if the corresponding returning or called method is non-void
LocationType locationType = rule.getTargetLocation().getLocationType();
if (locationType == LocationType.EXIT) {
if ("void".equals(getReturnBindingType())) {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found return value binding " + binding + " checking void trigger method " + name + descriptor + " in AT EXIT rule " + rule);
}
transformContext.warn(name, descriptor, "found return value binding " + binding + " checking void trigger method in AT EXIT rule");
}
} else if (locationType == LocationType.INVOKE_COMPLETED) {
if ("void".equals(getReturnBindingType())) {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found return value binding " + binding + " checking void called method in AFTER INVOKE rule " + rule.getName());
}
transformContext.warn(name, descriptor, "found return value binding " + binding + " checking void called method in AFTER INVOKE rule");
}
} else {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found return value binding " + binding + " in rule which is neither AT EXIT nor AFTER INVOKE " + rule.getName());
}
transformContext.warn(name, descriptor, "found return value binding " + binding + " in rule which is neither AT EXIT nor AFTER INVOKE");
}
} else if (binding.isThrowable()) {
// we can only allow reference to the current throwable in an AT THROW rule
LocationType locationType = rule.getTargetLocation().getLocationType();
if (locationType != LocationType.THROW && locationType != LocationType.EXCEPTION_EXIT) {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found throwable value binding " + binding + " in rule which is neither AT THROW nor AT EXCEPTION EXIT" + rule.getName());
}
transformContext.warn(name, descriptor, "found throwable value binding " + binding + " in rule which is not AT THROW");
}
// we will need to set the descriptor at some point
} else if (binding.isParamArray()) {
// this is ok
} else if (binding.isParamCount()) {
// this is ok
} else if (binding.isInvokeParamArray()) {
// we can only allow reference to the invoked method parameters in an AT INVOKE rule
if (rule.getTargetLocation().getLocationType() != LocationType.INVOKE) {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : found invoke parameter array binding $@ in non-AT INVOKE rule " + rule.getName());
}
transformContext.warn(name, descriptor, "found throwable value binding " + binding + " in rule which is not AT THROW");
}
} else if (binding.isTriggerClass() || binding.isTriggerMethod()) {
// this is ok
} else if (binding.isLocalVar()){
// make sure we have a local variable with the correct name
String localVarName = binding.getName().substring(1);
List<LocalVar> localVars = lookup(localVarName);
if (localVars == null || localVars.isEmpty()) {
if (Transformer.isVerbose()) {
System.out.println("RuleCheckMethodAdapter.checkBindings : unsatisfiable local variable binding " + binding + " checking method " + name + descriptor);
}
transformContext.warn(name, descriptor, "unknown local variable " + binding);
} else {
After Change
Binding binding = bindingIter.next();
if (binding.isRecipient()) {
if ((access & Opcodes.ACC_STATIC) != 0) {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found invalid recipient binding " + binding + " checking static method " + name + descriptor);
transformContext.warn(name, descriptor, "found invalid recipient binding " + binding + " injecting into static method");
}
} else if (binding.isParam()) {
int idx = binding.getIndex();
if (idx > parameterCount) {
// parameter out of range
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found out of range parameter binding " + binding + " checking method " + name + descriptor);
transformContext.warn(name, descriptor, "found out of range parameter binding " + binding);
} else {
binding.setDescriptor(parameterTypenames.get(idx - 1));
}
} else if (binding.isReturn()) {
// this is a valid reference in an AT EXIT rule and in an AFTER INVOKE
// but only if the corresponding returning or called method is non-void
LocationType locationType = rule.getTargetLocation().getLocationType();
if (locationType == LocationType.EXIT) {
if ("void".equals(getReturnBindingType())) {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found return value binding " + binding + " checking void trigger method " + name + descriptor + " in AT EXIT rule " + rule);
transformContext.warn(name, descriptor, "found return value binding " + binding + " checking void trigger method in AT EXIT rule");
}
} else if (locationType == LocationType.INVOKE_COMPLETED) {
if ("void".equals(getReturnBindingType())) {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found return value binding " + binding + " checking void called method in AFTER INVOKE rule " + rule.getName());
transformContext.warn(name, descriptor, "found return value binding " + binding + " checking void called method in AFTER INVOKE rule");
}
} else {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found return value binding " + binding + " in rule which is neither AT EXIT nor AFTER INVOKE " + rule.getName());
transformContext.warn(name, descriptor, "found return value binding " + binding + " in rule which is neither AT EXIT nor AFTER INVOKE");
}
} else if (binding.isThrowable()) {
// we can only allow reference to the current throwable in an AT THROW rule
LocationType locationType = rule.getTargetLocation().getLocationType();
if (locationType != LocationType.THROW && locationType != LocationType.EXCEPTION_EXIT) {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found throwable value binding " + binding + " in rule which is neither AT THROW nor AT EXCEPTION EXIT" + rule.getName());
transformContext.warn(name, descriptor, "found throwable value binding " + binding + " in rule which is not AT THROW");
}
// we will need to set the descriptor at some point
} else if (binding.isParamArray()) {
// this is ok
} else if (binding.isParamCount()) {
// this is ok
} else if (binding.isInvokeParamArray()) {
// we can only allow reference to the invoked method parameters in an AT INVOKE rule
if (rule.getTargetLocation().getLocationType() != LocationType.INVOKE) {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : found invoke parameter array binding $@ in non-AT INVOKE rule " + rule.getName());
transformContext.warn(name, descriptor, "found throwable value binding " + binding + " in rule which is not AT THROW");
}
} else if (binding.isTriggerClass() || binding.isTriggerMethod()) {
// this is ok
} else if (binding.isLocalVar()){
// make sure we have a local variable with the correct name
String localVarName = binding.getName().substring(1);
List<LocalVar> localVars = lookup(localVarName);
if (localVars == null || localVars.isEmpty()) {
Helper.verbose("RuleCheckMethodAdapter.checkBindings : unsatisfiable local variable binding " + binding + " checking method " + name + descriptor);
transformContext.warn(name, descriptor, "unknown local variable " + binding);
} else {