c335324f6321195bbf63ae8827f7bfb93491e8d0,Red5Pro/src/main/java/infrared5/com/red5proandroid/settings/SettingsDialogFragment.java,SettingsDialogFragment,saveAdvancedSettings,#,519
Before Change
}
else{
//error
getField(advancedSubView, R.id.serverText).setTextColor(Color.RED);
errorless = false;
}
//port
text = getField(advancedSubView, R.id.portText).getText().toString();
if(ValidationUtillity.ValidatePort(text)) {
editor.putInt(getPreferenceValue(R.string.preference_port), Integer.parseInt(text));
getField(advancedSubView, R.id.portText).setTextColor(Color.BLACK);
}
else {
//error
getField(advancedSubView, R.id.portText).setTextColor(Color.RED);
errorless = false;
}
//app
text = getField(advancedSubView, R.id.appText).getText().toString().trim();
if(ValidationUtillity.ValidateName(text)) {
editor.putString(getPreferenceValue(R.string.preference_app), text);
getField(advancedSubView, R.id.appText).setTextColor(Color.BLACK);
}
else{
//error
getField(advancedSubView, R.id.appText).setTextColor(Color.RED);
errorless = false;
}
//name
text = getField(advancedSubView, R.id.nameText).getText().toString().trim();
if(ValidationUtillity.ValidateName(text)) {
editor.putString(getPreferenceValue(R.string.preference_name), text);
getField(advancedSubView, R.id.nameText).setTextColor(Color.BLACK);
}
else {
//error
getField(advancedSubView, R.id.nameText).setTextColor(Color.RED);
errorless = false;
}
if( state == AppState.PUBLISH ) {
if( !preferences.getBoolean(getPreferenceValue(R.string.preference_audio), getResources().getBoolean(R.bool.preference_default_audio))
&& !preferences.getBoolean(getPreferenceValue(R.string.preference_video), getResources().getBoolean(R.bool.preference_default_video)) ) {
errorless = false;
getTextField(advancedSubView, R.id.av_error).setVisibility(View.VISIBLE);
}
else {
getTextField(advancedSubView, R.id.av_error).setVisibility(View.GONE);
}
//bitrate/resolution
int baseBitrate = preferences.getInt(getPreferenceValue(R.string.preference_bitrate), getResources().getInteger(R.integer.preference_default_bitrate));
int newBitrate = 0;
try {
newBitrate = Integer.parseInt(getField(advancedSubView, R.id.rateText).getText().toString().trim());
if( newBitrate <= 0 ) throw new Exception("Bitrate must be a positive integer");
getField(advancedSubView, R.id.rateText).setTextColor(Color.BLACK);
}catch (Exception e){
e.printStackTrace();
getField(advancedSubView, R.id.rateText).setTextColor(Color.RED);
editor.apply();
return false;
}
String newResolution = getField(advancedSubView, R.id.resolutionText).getText().toString().trim();
if(baseBitrate != newBitrate || !Publish.selected_item.equalsIgnoreCase(newResolution) ) {
if (newResolution.contains("x") && !newResolution.contains("-")) {
String[] bits = newResolution.split("x");
try {
if(Integer.parseInt(bits[0]) <= 0) throw new Exception("Resolution values must be greater than 0");
if(Integer.parseInt(bits[1]) <= 0) throw new Exception("Resolution values must be greater than 0");
} catch (Exception e) {
e.printStackTrace();
getField(advancedSubView, R.id.resolutionText).setTextColor(Color.RED);
editor.apply();
return false;
}
getField(advancedSubView, R.id.resolutionText).setTextColor(Color.BLACK);
} else {
getField(advancedSubView, R.id.resolutionText).setTextColor(Color.RED);
editor.apply();
After Change
}
else{
//error
ValidationUtillity.FlashRed( getField(advancedSubView, R.id.appText) );
errorless = false;
}
//name
text = getField(advancedSubView, R.id.nameText).getText().toString().trim();
if(ValidationUtillity.ValidateName(text)) {
editor.putString(getPreferenceValue(R.string.preference_name), text);
}
else {
//error
ValidationUtillity.FlashRed( getField(advancedSubView, R.id.nameText) );
errorless = false;
}
if( state == AppState.PUBLISH ) {
if( !preferences.getBoolean(getPreferenceValue(R.string.preference_audio), getResources().getBoolean(R.bool.preference_default_audio))
&& !preferences.getBoolean(getPreferenceValue(R.string.preference_video), getResources().getBoolean(R.bool.preference_default_video)) ) {
errorless = false;
getTextField(advancedSubView, R.id.av_error).setVisibility(View.VISIBLE);
}
else {
getTextField(advancedSubView, R.id.av_error).setVisibility(View.GONE);
}
//bitrate/resolution
int baseBitrate = preferences.getInt(getPreferenceValue(R.string.preference_bitrate), getResources().getInteger(R.integer.preference_default_bitrate));
int newBitrate = 0;
try {
newBitrate = Integer.parseInt(getField(advancedSubView, R.id.rateText).getText().toString().trim());
if( newBitrate <= 0 ) throw new Exception("Bitrate must be a positive integer");
}catch (Exception e){
e.printStackTrace();
ValidationUtillity.FlashRed( getField(advancedSubView, R.id.rateText) );
editor.apply();
return false;